[webkit-reviews] review requested: [Bug 12059] SVG colors have two
separate parsing paths (one CSS and one
SVGColor::setRGBColor) : [Attachment 16022] First attempt
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 19 10:08:09 PDT 2007
Rob Buis <rwlbuis at gmail.com> has asked for review:
Bug 12059: SVG colors have two separate parsing paths (one CSS and one
SVGColor::setRGBColor)
http://bugs.webkit.org/show_bug.cgi?id=12059
Attachment 16022: First attempt
http://bugs.webkit.org/attachment.cgi?id=16022&action=edit
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This tries to combine the two codepaths. Note that unfortunately I have to test
for rgba,hsl and hsla constructs. One way to avoid it may be to make the parser
aware that it is parsing svg css, but that
needs more discussion I suppose. One further thing that could fix is to parse
SVG color property and
deliver a SVGColor, not a CSSPrimitiveValue like now.
Cheers,
Rob.
More information about the webkit-reviews
mailing list