[webkit-reviews] review requested: [Bug 15006] webkitdirs.pm
contains to much code duplication for Qt and Gtk related
stuff : [Attachment 16021] refactoring of webkitdirs.pm
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 19 07:38:34 PDT 2007
Oleg Sukhodolsky <son.two at gmail.com> has asked for review:
Bug 15006: webkitdirs.pm contains to much code duplication for Qt and Gtk
related stuff
http://bugs.webkit.org/show_bug.cgi?id=15006
Attachment 16021: refactoring of webkitdirs.pm
http://bugs.webkit.org/attachment.cgi?id=16021&action=edit
------- Additional Comments from Oleg Sukhodolsky <son.two at gmail.com>
To make buildQMakeGdkProject()/buildQMakeQtProject() as similar as possible
I've decided to only use "qmake" for build (before gtk port tried to use
qmake-qt4 first). But since it is possible now to configure qmake which will
be used with "--qmake" cli option, it should not be a big problem.
Also I've decided to not place the check for directory ($project) for which
build is called in common area since I see no advantages from this.
Note, that I have not tested this with Qt build, freyther has agreed to do this
for me (thanks in advance btw :)
More information about the webkit-reviews
mailing list