[webkit-reviews] review denied: [Bug 12878] Support for each (var in collection) syntax : [Attachment 15791] Updated Patch for for each...in

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Justin Haygood
<jhaygood at spsu.edu>'s request for review:
Bug 12878: Support for each (var in collection) syntax
http://bugs.webkit.org/show_bug.cgi?id=12878

Attachment 15791: Updated Patch for for each...in
http://bugs.webkit.org/attachment.cgi?id=15791&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
There is still incorrect whitespace and * placement in many places.  You should
also include a test case as part of the patch, along with the related changelog
entry.

+					     Node *n =
$4->nodeInsideAllParens();

+JSValue* ForInNode::getIteratorValue( ExecState*, JSObject* inValue, const
Identifier name )

+      JSValue *str = getIteratorValue(exec,v,name);

+JSValue* ForEachInNode::getIteratorValue(ExecState* exec, JSObject* inValue,
const Identifier name )

+    virtual JSValue* getIteratorValue( ExecState *exec, JSObject *inValue,
const Identifier name ) KJS_FAST_CALL;


+    ForEachInNode(Node *l, Node *e, StatementNode *s) KJS_FAST_CALL;
+    ForEachInNode(const Identifier &i, AssignExprNode *in, Node *e,
StatementNode *s) KJS_FAST_CALL;
+  protected:
+    virtual JSValue* getIteratorValue( ExecState *exec, JSObject *inValue,
const Identifier name ) KJS_FAST_CALL;