[webkit-reviews] review requested: [Bug 13445] NodeList access by index is slow : [Attachment 14161] easy way out

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 13445: NodeList access by index is slow
http://bugs.webkit.org/show_bug.cgi?id=13445

Attachment 14161: easy way out
http://bugs.webkit.org/attachment.cgi?id=14161&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Just add support for iterating backwards. On my machine, results on the "Index"
test look OK now (~7000 ms TOT, ~100 ms TOT + this patch, ~120 ms Opera, ~1300
ms Firefox).

KHTML also has support for iterating backwards, and according to Maks Orlovich,
it was added to fix a real site, forums.tweakers.nl. I've also added support
for iteration from lastChild.

I still think that there might be a better data structure for a list of child
nodes in ContainerNode, and that would speed up other operations, too.
Obviously, performance of data structures is always a trade-off, so it would
probably take someone with access to PLT to play with it.