[webkit-reviews] review granted: [Bug 13471] REGRESSION (r21045): Secure keyboard entry mode remains in effect after leaving a password field by submitting : [Attachment 14160] Reset secure entry mode in setDocument

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 13:07:33 PDT 2007


Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 13471: REGRESSION (r21045): Secure keyboard entry mode remains in effect
after leaving a password field by submitting
http://bugs.webkit.org/show_bug.cgi?id=13471

Attachment 14160: Reset secure entry mode in setDocument
http://bugs.webkit.org/attachment.cgi?id=14160&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I do like the idea of "going all the way" and eliminating the friendship, but I
don't see any need to do this as part of this patch.

setDocument should be changed to take a PassRefPtr.

r=me



More information about the webkit-reviews mailing list