[webkit-reviews] review granted: [Bug 13471] REGRESSION (r21045): Secure keyboard entry mode remains in effect after leaving a password field by sumbitting : [Attachment 14157] Reset secure keyboard entry mode in Frame::setView

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 13471: REGRESSION (r21045): Secure keyboard entry mode remains in effect
after leaving a password field by sumbitting
http://bugs.webkit.org/show_bug.cgi?id=13471

Attachment 14157: Reset secure keyboard entry mode in Frame::setView
http://bugs.webkit.org/attachment.cgi?id=14157&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Why not spell it "submit" everywhere?

What's the key reason this needs to be called? Is it really the change in view
that's the issue? Doesn't the input element lose focus? I think this fix is
fine, but it would be stronger if I understood exactly why this is the right
point in time to clear this. It has to have something about the input that was
sponsoring secure keyboard entry.

r=me