[webkit-reviews] review requested: [Bug 13471] REGRESSION (r21045): Secure keyboard entry mode remains in effect after leaving a password field by sumbitting : [Attachment 14157] Reset secure keyboard entry mode in Frame::setView

[bugzilla-daemon at webkit.org]

mitz at webkit.org has asked  for review:
Bug 13471: REGRESSION (r21045): Secure keyboard entry mode remains in effect
after leaving a password field by sumbitting
http://bugs.webkit.org/show_bug.cgi?id=13471

Attachment 14157: Reset secure keyboard entry mode in Frame::setView
http://bugs.webkit.org/attachment.cgi?id=14157&action=edit

------- Additional Comments from mitz at webkit.org
The reason why you can reset to false unconditionally is that pages containing
password fields are not allowed in the page cache, so you know that in
setView() you're never entering a page with a focused password field.

If you think it's necessary, I can add a FIXME in FrameLoader::canCachePage()
saying that if you ever decide to allow password fields in the page cache, then
you should address this problem.