[webkit-reviews] review denied: [Bug 11607] Possible optimization in RenderBlock::calcMinMaxWidth() : [Attachment 14016] Possible patch adapting the fix from Bug 12049.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 13:27:42 PDT 2007


Dave Hyatt <hyatt at apple.com> has denied Brian Heung <bheung at apple.com>'s
request for review:
Bug 11607: Possible optimization in RenderBlock::calcMinMaxWidth()
http://bugs.webkit.org/show_bug.cgi?id=11607

Attachment 14016: Possible patch adapting the fix from Bug 12049.
http://bugs.webkit.org/attachment.cgi?id=14016&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
The way flexible boxes are eventually going to work is that width will not
dictate the minwidth or maxwidth.  That makes this optimization (eventually)
pretty irrelevant for flexboxes.

Also a flexbox can't ever be a table cell so the !isTableCell() bit is
unnecessary.



More information about the webkit-reviews mailing list