[webkit-reviews] review granted: [Bug 13398] [GDK] Bring the port up to date : [Attachment 14080] gdk port build fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 14:05:07 PDT 2007

Sam Weinig <sam at webkit.org> has granted Alp Toker <alp at atoker.com>'s request
for review:
Bug 13398: [GDK] Bring the port up to date

Attachment 14080: gdk port build fixes

------- Additional Comments from Sam Weinig <sam at webkit.org>
This seems fine except for 2 nit picks.  First, there are a couple tabs in the
ChangeLog that should be removed before landing.  Second, there should be a
space after the "return 0;" here:

+WebCore::Page* ChromeClientGdk::createModalDialog(Frame*, const
FrameLoadRequest&) { notImplementedGdk(); return 0;}

Otherwise, r=me.

More information about the webkit-reviews mailing list