[webkit-reviews] review granted: [Bug 13386] [js-collector-tweaks] Shrink Array by 4 bytes : [Attachment 14067] 06-js-gc-array-shrink.patch.txt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 11:18:23 PDT 2007


Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 13386: [js-collector-tweaks] Shrink Array by 4 bytes
http://bugs.webkit.org/show_bug.cgi?id=13386

Attachment 14067: 06-js-gc-array-shrink.patch.txt
http://bugs.webkit.org/attachment.cgi?id=14067&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+  JSValue** storage = ((JSValue **)fastCalloc(capacity + 1, sizeof(JSValue
*))) + 1;

I'd like to see this use static_cast rather than C-style cast, and put the *
next to JSValue instead of including a space.

+    storage =	allocateStorage(newCapacity);

Two spaces after the equal sign.

+  storage = ((JSValue **)fastRealloc(storage - 1, (newCapacity + 1) * sizeof
(JSValue*))) + 1;

static_cast again.

r=me



More information about the webkit-reviews mailing list