[webkit-reviews] review granted: [Bug 13385] [js-collector-tweaks] Shrink List (and therefore ActivationImp), discard arguments List when no longer needed : [Attachment 14066] 05-js-gc-arguments-discard+list-shrink.patch.txt

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 13385: [js-collector-tweaks] Shrink List (and therefore ActivationImp),
discard arguments List when no longer needed
http://bugs.webkit.org/show_bug.cgi?id=13385

Attachment 14066: 05-js-gc-arguments-discard+list-shrink.patch.txt
http://bugs.webkit.org/attachment.cgi?id=14066&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    if (activation)
+      activation->_arguments.reset();

This is 2-space indented in a 4-space-indented function.

+    friend class Context;

I'd really prefer to see this done with a public function instead of making
Context a friend.

I think we can make additional simplifications to List if we don't need the
!_needsMarking version.

r=me