[webkit-reviews] review granted: [Bug 13382] [js-collector-tweaks] Remove JS oversize allocator : [Attachment 14063] 02-js-gc-forbid-oversize.patch.txt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 11:02:24 PDT 2007

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 13382: [js-collector-tweaks] Remove JS oversize allocator

Attachment 14063: 02-js-gc-forbid-oversize.patch.txt

------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine.

I would have suggested using a simpler approach for CellSize, using
sizeof(void*) as the parmaeter rather than the two booleans, as in the IntTypes
template in HashFunctions.h.

More information about the webkit-reviews mailing list