[webkit-reviews] review denied: [Bug 13381] [js-collector-tweaks] Make Window object not an oversize object any more : [Attachment 14062] 01-js-gc-window-not-oversize.patch.txt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 10:58:26 PDT 2007


Darin Adler <darin at apple.com> has denied Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 13381: [js-collector-tweaks] Make Window object not an oversize object any
more
http://bugs.webkit.org/show_bug.cgi?id=13381

Attachment 14062: 01-js-gc-window-not-oversize.patch.txt
http://bugs.webkit.org/attachment.cgi?id=14062&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Optimization level changes should be done in Configurations/Base.xcconfig
instead of in the project.pbxproj.

Change otherwise looks fine to me. Although I'm not crazy about the name "d".



More information about the webkit-reviews mailing list