[webkit-reviews] review requested: [Bug 10893] InsertRule can not handle @import statements : [Attachment 10832] Improved patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Sep 29 01:18:35 PDT 2006


Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 10893: InsertRule can not handle @import statements
http://bugzilla.opendarwin.org/show_bug.cgi?id=10893

Attachment 10832: Improved patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10832&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This patch should address Darin's issues. I tested that it is in fact possible
to insert the
@import at positions > 0. Since FF also allows it, I do not think it is a big
deal. Let me know
whether there should be a check added if it is a big deal though.
Thanks to Maciej for helping with CSSGrammar.y.
Cheers,

Rob.



More information about the webkit-reviews mailing list