[webkit-reviews] review requested: [Bug 4980] CSS2: Counters not supported : [Attachment 10831] another round

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Sep 29 00:05:38 PDT 2006


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 4980: CSS2: Counters not supported
http://bugzilla.opendarwin.org/show_bug.cgi?id=4980

Attachment 10831: another round
http://bugzilla.opendarwin.org/attachment.cgi?id=10831&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
This patch addresses Darin's last round of comments. I am pretty sure that I
have addressed everything, thought I could be wrong. In Counter.h, I left the
listStyle as an integer because I check to make sure it is a valid list style
number from within the parser. Perhaps that is insufficient, though? What do
you think?

(Oh, and Darin, just so you know, I fixed that crazy crasher that I showed to
you earlier today, so that is all set. It was utterly bizarre; I will tell you
about it later.)



More information about the webkit-reviews mailing list