[webkit-reviews] review requested: [Bug 10824] REGRESSION: "no file selected" placeholder text missing from file upload control : [Attachment 10610] Use a RenderBlock instead of a RenderFlexibleBox to hold the filename

[bugzilla-request-daemon at opendarwin.org]

Adam Roben <aroben at apple.com> has asked  for review:
Bug 10824: REGRESSION: "no file selected" placeholder text missing from file
upload control
http://bugzilla.opendarwin.org/show_bug.cgi?id=10824

Attachment 10610: Use a RenderBlock instead of a RenderFlexibleBox to hold the
filename
http://bugzilla.opendarwin.org/attachment.cgi?id=10610&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
(Fix suggested by Hyatt) This patch fixes the problem by making
RenderFileUploadInnerFileBox a subclass of RenderBlock instead of
RenderFlexibleBox. Ultimately, we should handle the truncation of the filename
in the engine, which would get rid of this problem in a much better way and we
wouldn't need to call updateIconAndFilename() from within layout(). See
rdar://problem/4736216 for more info.