[webkit-reviews] review granted: [Bug 10899] REGRESSION: font-size: small not being honored properly : [Attachment 10607] Patch that reworks how keyword font sizes are computed.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 17 15:33:22 PDT 2006


Adam Roben <aroben at apple.com> has granted Adam Roben <aroben at apple.com>'s
request for review:
Bug 10899: REGRESSION: font-size: small not being honored properly
http://bugzilla.opendarwin.org/show_bug.cgi?id=10899

Attachment 10607: Patch that reworks how keyword font sizes are computed.
http://bugzilla.opendarwin.org/attachment.cgi?id=10607&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+    void setKeywordSize(int s) { m_keywordSize = s; }

I'd say to make this "const int", but the other setter methods don't seem to do
that...

+    int m_keywordSize : 4;

Shouldn't this be "unsigned" instead of "int"?

Other than those, r=me



More information about the webkit-reviews mailing list