[webkit-reviews] review requested: [Bug 11268] Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint : [Attachment 11054] patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Oct 12 14:23:40 PDT 2006


Sam Weinig <sam.weinig at gmail.com> has asked  for review:
Bug 11268: Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and
SVGPoint
http://bugs.webkit.org/show_bug.cgi?id=11268

Attachment 11054: patch
http://bugs.webkit.org/attachment.cgi?id=11054&action=edit

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
- Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.

- Moves the contents of ksvg/bindings/js/ to bindings/js/.

- Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.

- Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching the other
CSSValue classing, and allowing the bindings to allocate appropriately.

- Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing
generation for Objective-C.

- Assorted style cleanups.



More information about the webkit-reviews mailing list