[webkit-reviews] review requested: [Bug 11250] File upload form control isn't finished on Windows : [Attachment 11053] Patch to make it work

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Oct 12 13:48:19 PDT 2006


Marvin Decker <marv.decker at gmail.com> has asked  for review:
Bug 11250: File upload form control isn't finished on Windows
http://bugs.webkit.org/show_bug.cgi?id=11250

Attachment 11053: Patch to make it work
http://bugs.webkit.org/attachment.cgi?id=11053&action=edit

------- Additional Comments from Marvin Decker <marv.decker at gmail.com>
This patch separates out the file upload controls from TemporaryLinkStubs into
a new file. It implements the basic functionality necessary to open the
standard Windows open file dialog and to set the filename back into the
control.

Unimplemented is fancy splitting of the filename, so it will just get cut off
if the control isn't wide enough.

This also has a spacing change to the vcproj for WebCore. Visual Studio will
"fix" this every time somebody changes the file, so we should fix it to prevent
everybody from having to manually factor it out of their diff.



More information about the webkit-reviews mailing list