[webkit-reviews] review requested: [Bug 6915] fast/js/date-constructor.html testcase is timezone-dependent : [Attachment 8370] remove the offending tests

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed May 17 12:58:05 PDT 2006


Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 6915: fast/js/date-constructor.html testcase is timezone-dependent
http://bugzilla.opendarwin.org/show_bug.cgi?id=6915

Attachment 8370: remove the offending tests
http://bugzilla.opendarwin.org/attachment.cgi?id=8370&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
The problem here is that normalization of the year to 1970...2038 doesn't work
because of the large month value: even though we first convert year 1111 to the
desired range, the 92+ years disguised as 1111 months cause clipping in
mktime(), and the resulting year is always 2038.

The current results are incorrect even for US/Pacific time zone. And Firefox
doesn't seem to work properly here, too - the results of these two tests depend
on the time zone, which likely indicates a bug somewhere. 

I couldn't come up with a good solution to this (of course, it's easy to divide
months by 12 and add the result to years, but then the problem remains for
large day values). So, this patch just disables the tests.



More information about the webkit-reviews mailing list