[webkit-reviews] review requested: [Bug 8958] Should be able to have custom implementations for JS methods : [Attachment 8368] Add [Custom] keyword and port JSCanvasRenderingContext2D over to it

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed May 17 12:16:51 PDT 2006


Anders Carlsson <andersca at mac.com> has asked  for review:
Bug 8958: Should be able to have custom implementations for JS methods
http://bugzilla.opendarwin.org/show_bug.cgi?id=8958

Attachment 8368: Add [Custom] keyword and port JSCanvasRenderingContext2D over
to it
http://bugzilla.opendarwin.org/attachment.cgi?id=8368&action=edit

------- Additional Comments from Anders Carlsson <andersca at mac.com>
There are two things I'm unsure about with this patch:

* The custom functions in CanvasRenderingContext2D are vararg functions, and
I've indicated this by adding /* ... */ as arguments to them. The problem with
this is that the length property of the function won't be correct.

* I don't like the "custom" type that's used for properties. Perhaps "object"
or "any" is a better choice?



More information about the webkit-reviews mailing list