[webkit-reviews] review granted: [Bug 5393] Anchor links do not jump to ID attributes on table row elements : [Attachment 7110] Rework things to make the internal absolutePosition recursion just always correct. Add a new absolutePositionForContent method for the case where you want the inner box instead.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Mar 16 08:49:11 PST 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 5393: Anchor links do not jump to ID attributes on table row elements
http://bugzilla.opendarwin.org/show_bug.cgi?id=5393

Attachment 7110: Rework things to make the internal absolutePosition recursion
just always correct.   Add a new absolutePositionForContent method for the case
where you want the inner box instead.
http://bugzilla.opendarwin.org/attachment.cgi?id=7110&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
That one place in RenderObject::absoluteBoundingBoxRect looks like it should
call absolutePositionForContent instead of adding in borderTopExtra.

There's still an issue with having to know when to use
absolutePositionForContent, but I think this is way easier to understand than
the extra bool was.

Looks good to me, r=me.



More information about the webkit-reviews mailing list