[webkit-reviews] review granted: [Bug 7803] Various (some hackish) improvements to Win32 support : [Attachment 7112] First cut at a patch containing these varied changes.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Mar 16 08:43:27 PST 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 7803: Various (some hackish) improvements to Win32 support
http://bugzilla.opendarwin.org/show_bug.cgi?id=7803

Attachment 7112: First cut at a patch containing these varied changes.
http://bugzilla.opendarwin.org/attachment.cgi?id=7112&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    return (float)runSize.width();

I'm surprised you need that cast.

+using namespace WebCore;
+
 #include "JSCanvasRenderingContext2DBaseTable.cpp"

I think that "using namespace" should go after the
JSCanvasRenderingContext2DBaseTable.cpp include.

Looks fine, r=me.



More information about the webkit-reviews mailing list