[webkit-reviews] review requested: [Bug 7602] Only use fixupChar for entities : [Attachment 6857] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Mar 4 14:15:11 PST 2006

Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 7602: Only use fixupChar for entities

Attachment 6857: proposed patch

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
Besides limiting fixupChar to entities, this removes a semi-broken Latin-1
special case from StreamingTextDecoder. As it stood, this special case was
pushing both Latin-1 and windows-1252 into QString's ASCII buffer, which was
then converted to Unicode in QString::makeUnicode, as if it were Latin-1. Since
the tokenizer called fixupChar on the result, it (usually?) didn't matter,

If this change negatively affects performance, then we will probably need to
postulate that QString's ASCII buffer in fact contains windows-1252 data, and
adjust makeUnicode accordingly.

More information about the webkit-reviews mailing list