[webkit-reviews] review denied: [Bug 7602] Only use fixupChar for entities : [Attachment 6857] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Mar 4 16:44:23 PST 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 7602: Only use fixupChar for entities

Attachment 6857: proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
Two issues prevent landing this:

    1) We need to do performance testing. When I added a fast case for Latin-1
that relied on fixupChar, we saw a significant performance boost. Even if we
don't need the super-fast "just put it in the ASCII buffer" version, we'll
probably need to consider making a path that does not go through ICU.
    2) I believe this may remove the quirk in our existing code that ISO
Latin-1 effectively means Windows Latin-1 -- I believe we need that quirk.

Maybe Alexey can handle issue (2). Someone at Apple will probably have to
tackle (1) since we haven't yet found a good way to measure performance that
people outside the Safari team can do easily.

More information about the webkit-reviews mailing list