[webkit-reviews] review requested: [Bug 6616] Double-clicking on a search result seems broken : [Attachment 6830] Patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Mar 3 14:31:31 PST 2006


Timothy Hatcher <timothy at hatcher.name> has asked  for review:
Bug 6616: Double-clicking on a search result seems broken
http://bugzilla.opendarwin.org/show_bug.cgi?id=6616

Attachment 6830: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6830&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This patch mainly fixes this bug, however it has cleanup and fixes for other
minor bugs.

<rdar://problem/4411822> wrong element shown in Inspector inspecting main image
at apple.com
<rdar://problem/4411908> in the Web Inspector, state of disclosure triangles
should be preserved after search
http://bugzilla.opendarwin.org/show_bug.cgi?id=6616
Bug 6616: Double-clicking on a search result seems broken
http://bugzilla.opendarwin.org/show_bug.cgi?id=6709
Bug 6709: TypeError: Value undefined (result of expression
treeScrollbar.refresh) is not object.

Code clean up and move more code into JavaScript.
Removes a few unused ObjC methods.
Many search fixes. Reveals the focused node when exiting the search.
Shows a "No Selection" screen when there are no search results.
Shows a node count for the number of results.
Fixes a couple of TypeErrors that show on the console.
Uses the system selection color in the Style pane tables.



More information about the webkit-reviews mailing list