[webkit-reviews] review requested: [Bug 7555] :hover style not applied on hover if its display property is different from original style's : [Attachment 6828] Patch

[bugzilla-request-daemon at opendarwin.org]

opendarwin.org at mitzpettel.com has asked  for review:
Bug 7555: :hover style not applied on hover if its display property is
different from original style's
http://bugzilla.opendarwin.org/show_bug.cgi?id=7555

Attachment 6828: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6828&action=edit

------- Additional Comments from opendarwin.org at mitzpettel.com
Indeed, attach() can cause a subframe to load and run JavaScript that removes
the element (in practice, this only increases the elements refcount after
attach() since it's referenced by JavaScript objects pending GC). Therefore in
this patch activeNode is a RefPtr and I added a ref/deref. This does not
address the issue of callers to recalcStyle() assuming that it won't deallocate
(or even just move the element). Thus the ref/deref is a non-solution to this
non-problem...

Following up on my previous comment, this patch does not rebuild the hover
chain but does recreate the active chain.

I also did as Darin had suggested in the end of comment #3.