[webkit-reviews] review requested: [Bug 7150] TinyMCE: Undo still enabled after a location change : [Attachment 6806] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Mar 2 00:15:39 PST 2006

Justin Garcia <justin.garcia at apple.com> has asked  for review:
Bug 7150: TinyMCE: Undo still enabled after a location change

Attachment 6806: patch

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
undo/redo operations registered by subframes weren't cleared on a location
change.  clearUndoRedoOperations was only called from didOpenURL, and thus was
only called for the main frame.  At first I tried calling it for all
childFrames in didOpenURL, but by the time that didOpenURL is called, all of
the subframes have already been detached/destroyed.  So I moved the call to
clearUndoRedoOperations to closeURL, and it is now called for subframes as they
are detached.

More information about the webkit-reviews mailing list