[webkit-reviews] review granted: [Bug 7547] Add a simple first-stab GraphicsContextCairo : [Attachment 6804] first stab at a Cairo Graphics Context

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Mar 2 00:14:29 PST 2006


Anders Carlsson <andersca at mac.com> has granted Anders Carlsson
<andersca at mac.com>'s request for review:
Bug 7547: Add a simple first-stab GraphicsContextCairo
http://bugzilla.opendarwin.org/show_bug.cgi?id=7547

Attachment 6804: first stab at a Cairo Graphics Context
http://bugzilla.opendarwin.org/attachment.cgi?id=6804&action=edit

------- Additional Comments from Anders Carlsson <andersca at mac.com>
Looks good, a few comments:

* cairo_save and cairo_restore saves and restores the aa setting, so there's no
need to manually store the previous setting and restore it.

* cairo_new_path shouldn't be needed, since all path drawing sequences end with
either cairo_stroke or cairo_fill, which clears the current path.



More information about the webkit-reviews mailing list