[webkit-reviews] review denied: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9093] Custom implementations of time functions

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 9651: MSVCRT time functions are too strict
http://bugzilla.opendarwin.org/show_bug.cgi?id=9651

Attachment 9093: Custom implementations of time functions
http://bugzilla.opendarwin.org/attachment.cgi?id=9093&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This seems like too much platform-specific code to put into this file.

I suggest putting it somewhere in WTF instead, maybe a file named
<wtf/DateExtras.h>. Maybe we can move the Mac-specific data locale code there
too.

+    //if (secs < time_tMin || secs > time_tMax) {

We don't check in commented-out code.

While the reformatting is fine, ideally I'd like to see that in a separate
patch rather than in the same patch as a substantive change to the file. Maybe
we can get that in first.

I think it's not so great to have a KJS::tm on the Windows platform and a
global tm on all the others. Maybe we can use a typedef instead?