[webkit-reviews] review denied: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9128] MS CRT fmod bug workaround where x % (1/0) = NaN, not x.

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 9678: fmod function of MS CRT returns NaN for x / Inf
http://bugzilla.opendarwin.org/show_bug.cgi?id=9678

Attachment 9128: MS CRT fmod bug workaround where x % (1/0) = NaN, not x.
http://bugzilla.opendarwin.org/attachment.cgi?id=9128&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'd like to see this workaround in MathExtras.h rather than inline in the
JavaScript-specific files. We just need a name for the fmod with the
workaround, and then we can use that. It can be an inline that expands to a
call to fmod on platforms other than Win32.

Also, we do COMPILER(MSVC) rather than _MSC_VER for these kinds of ifdefs.

I don't think we need PLATFORM(WIN) at all -- probably COMPILER(MSVC) is the
whole check needed.