[webkit-reviews] review granted: [Bug 6888] Collapsed borders appear on the wrong side or on the wrong cell in RTL tables : [Attachment 6072] Updated patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jan 29 08:52:28 PST 2006


Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 6888: Collapsed borders appear on the wrong side or on the wrong cell in
RTL tables
http://bugzilla.opendarwin.org/show_bug.cgi?id=6888

Attachment 6072: Updated patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6072&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks great. I think it's ready to land, but I do have 2 more ideas to improve
it. I'll probably just do these if I land it:

    1) cellPrevious and cellNext should be named cellBefore and cellAfter to
match the names cellAbove and cellBelow
    2) code to compute leftmostColumn and rightmostColumn should have more
closely-matching sides of the if, no need to use an if statement in the RTL
case



More information about the webkit-reviews mailing list