[webkit-reviews] review granted: [Bug 6888] Collapsed borders appear on the wrong side or on the wrong cell in RTL tables : [Attachment 6050] Proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jan 28 16:53:14 PST 2006


Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 6888: Collapsed borders appear on the wrong side or on the wrong cell in
RTL tables
http://bugzilla.opendarwin.org/show_bug.cgi?id=6888

Attachment 6050: Proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6050&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I think it's a little inelegant to have that inLastColumn boolean and those
"rtl ? !inLastColumn : (col() > 0)" clauses. Instead, could we just compute an
appropriate boolean up front? Something like "righmostColumn" or
"leftmostColumn"?

Looks great to me. r=me



More information about the webkit-reviews mailing list