[webkit-reviews] review granted: [Bug 6025] CDF example renders SVG on top of text : [Attachment 6044] proposed patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6025: CDF example renders SVG on top of text
http://bugzilla.opendarwin.org/show_bug.cgi?id=6025

Attachment 6044: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6044&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Generally we put spaces around "=" as in:

    isRootLineBox=false

I'd rather see C++ casts, like static_cast, then C-style casts in this code.

Since virtual function calls are never inlined, it's usually best to put the
implementations of virtual functions in a .cpp file rather than a header.

Is there a test that goes with this?

r=me