[webkit-reviews] review granted: [Bug 6025] CDF example renders SVG on top of text : [Attachment 6044] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jan 28 16:49:55 PST 2006

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6025: CDF example renders SVG on top of text

Attachment 6044: proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
Generally we put spaces around "=" as in:


I'd rather see C++ casts, like static_cast, then C-style casts in this code.

Since virtual function calls are never inlined, it's usually best to put the
implementations of virtual functions in a .cpp file rather than a header.

Is there a test that goes with this?


More information about the webkit-reviews mailing list