[webkit-reviews] review denied: [Bug 3702] Web page is laid out
incorrectly after printing with print-specific style sheet :
[Attachment 5841] revised fix
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Jan 22 10:51:40 PST 2006
Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 3702: Web page is laid out incorrectly after printing with print-specific
style sheet
http://bugzilla.opendarwin.org/show_bug.cgi?id=3702
Attachment 5841: revised fix
http://bugzilla.opendarwin.org/attachment.cgi?id=5841&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
The way the new recalcSections code iterates the sections is incorrect and
unnecessarily complicated. Instead, iterate all children (starting with the
first child, not firstBody), call the loop variable child instead of body,
handle all table sections, and don't special case the head or the foot.
Other than this complaint, the patch looks great!
(Patch has some tab characters in it. Please don't check in with tabs.)
More information about the webkit-reviews
mailing list