[webkit-reviews] review denied: [Bug 5874] WebCore+SVG needs support for "evt" instead of event : [Attachment 5836] addressed Darin's concerns

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jan 22 10:46:21 PST 2006

Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 5874: WebCore+SVG needs support for "evt" instead of event

Attachment 5836: addressed Darin's concerns

------- Additional Comments from Darin Adler <darin at apple.com>
I don't like the underscore-prefixed name for the local variable. We should
steer away from underscore prefixes in general since they are reserved for the
library and platform.

Patch does not include JSSVGLazyEventListener.h and .cpp so I couldn't review
them. Because of that, review-.

More information about the webkit-reviews mailing list