[webkit-reviews] review granted: [Bug 6468] Remove CFDictionary from KWQObject.* : [Attachment 5597] proposed patch.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Jan 10 07:05:11 PST 2006

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6468: Remove CFDictionary from KWQObject.*

Attachment 5597: proposed patch.

------- Additional Comments from Darin Adler <darin at apple.com>
It seems strange to have a takeRunLoopTimer function in KWQObjectTimer since
all of KWQObjectTimer's fields are public. If we're going to have a function to
set a data member, then I think this should be a class with private data
members. But if we're going to be a struct with public data members then it
seems we should just use assignment instead of an inline function that does the

Otherwise, looks great. r=me

More information about the webkit-reviews mailing list