[webkit-reviews] review denied: [Bug 6465] Replace CFDictionary in KWQAccessibilityCache with HashMap : [Attachment 5596] Better fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Jan 10 07:01:12 PST 2006

Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 6465: Replace CFDictionary in KWQAccessibilityCache with HashMap

Attachment 5596: Better fix

------- Additional Comments from Darin Adler <darin at apple.com>
Since you're passing the hash traits in explicitly when declaring
AccIdToAccObjectMap the traits should a plain old struct instead of a template,
and needn't be in the KXMLCore namespace at all. (Note also, the specialization
of HashTraits for KWQAccObjectID is misleading. It's really a specialization
for unsigned int that works for any unsigned int. But that's all beside the
point because you don't need to specialize the template.)

Also, m_accCache and m_accCacheByID should just be hash maps rather than
pointers to hash maps.

Patch looks great.

More information about the webkit-reviews mailing list