[webkit-reviews] review denied: [Bug 5353] DrawTest should subclass WebView instead of DrawView : [Attachment 5533] Patch to fix the broken DrawTest compile

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has denied Nefaur Khandker
<nefaurk at gmail.com>'s request for review:
Bug 5353: DrawTest should subclass WebView instead of DrawView
http://bugzilla.opendarwin.org/show_bug.cgi?id=5353

Attachment 5533: Patch to fix the broken DrawTest compile
http://bugzilla.opendarwin.org/attachment.cgi?id=5533&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
There are a number of things we'll need to fix before landing.

First of all, we don't generally commit commented out code, or logging/debug
code.  In this case, we'll have to make an exception (since bringing all of
DrawTest back and working in one pass is probably not reasonable).  However,
the large sections of code which you'd like to disable should use #if 0 instead
of // all other new commented code (like header files, etc.) should be removed.


It looks like your change to DrawTestDocument.nib is a noop.  I would just
remove it from this patch.

Try those couple changes and re-post.  Also, eventually we'll need to have you
post a ChangeLog as part of your patch (prepare-ChangeLog will do that for
you).

Finally, any files you change should include your copyright.  Just use the same
format we do

Copyright (C) 2006 Nefaur Khandker <nefaurk at gmail.com>	All rights reserved.

Thanks.