[webkit-reviews] review denied: [Bug 5748] KCanvas needs to be redesigned to fill & stroke at once : [Attachment 5536] broken patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jan 7 22:32:05 PST 2006

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 5748: KCanvas needs to be redesigned to fill & stroke at once

Attachment 5536: broken patch

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
A few comments:

should now be part of draw.  If something needs to fill, it fetches it's paint
server, it sets the active client (that will go away after my next patch) and
then paints with that paint server.

fillPaintServer should be a static method:
canvasStyle()->fillPaintServer(style(), this)
KCanvasRenderingStyle::fillPaintServer(style(), getDocument())

fillPaintServer(), strokePaintServer() shoudl return *shared* instances for
solid and image paint servers.	In fact, PaintServerImage is slated to die, it
just hasn't yet.

disableFillPainter() and disableStrokePainter() should no longer be necessary.

More information about the webkit-reviews mailing list