[webkit-reviews] review denied: [Bug 6402] Implement frameElement.width and frameElement.height : [Attachment 5518] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Jan 6 22:06:17 PST 2006

Geoffrey Garen <ggaren at apple.com> has denied Alexey Proskuryakov
<ap at nypop.com>'s request for review:
Bug 6402: Implement frameElement.width and frameElement.height

Attachment 5518: proposed patch

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I second Eric's question: why virtual?

The alert will work in the layout test, but it can be kinda annoying when you
open that page manually. An explanation of what you're testing and a reference
to the related bug are also important and missing. Check out
LayoutTests/fast/js/string-split-ignore-case.html for an example. It also
demonstrates how to produce output without an alert.

More information about the webkit-reviews mailing list