[webkit-reviews] review denied: [Bug 5748] KCanvas needs to be redesigned to fill & stroke at once : [Attachment 5516] move paintserver/draw from fill/stroke painters into the callers

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has denied Alexander Kellett
<webkit at lypanov.net>'s request for review:
Bug 5748: KCanvas needs to be redesigned to fill & stroke at once
http://bugzilla.opendarwin.org/show_bug.cgi?id=5748

Attachment 5516: move paintserver/draw from fill/stroke painters into the
callers
http://bugzilla.opendarwin.org/attachment.cgi?id=5516&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
We talked online.  Although this is a good patch, I think that it makes more
sense (in terms of process overhead) to go a bit further along the removal
process first.

I encoruaged Alexander to take the approache of just removing all the set*
methods on KCanvasRenderingStyle and making all of the get methods dynamically
compute/lookup, etc. all the necessary info.  That way none of the callers have
to change (more than they have in this patch), but KCanvasRenderingStyle
becomes a complete no-op and we can get rid of more of this uncessary code in
one fell swoop.

I also encoruaged alexander to make sure that he posts layout test changes, and
is sure to test with --leaks.