[webkit-reviews] review denied: [Bug 3230] CSS1: Words with inline elements get extra capital letters : [Attachment 6458] Proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Feb 13 11:37:14 PST 2006

Dave Hyatt <hyatt at apple.com> has denied Andrew Wellington
<proton at wiretapped.net>'s request for review:
Bug 3230: CSS1: Words with inline elements get extra capital letters

Attachment 6458: Proposed patch

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
+		     for (o = previousRenderer(); o && o->isInline() &&
!o->isText(); o = o->previousRenderer())

This will include images that occur between words, e.g.,


I'm not sure that's right.  You might want to see what other browsers do.

+			 ;
+		     if (o && o->isText()) {
+			 DOMStringImpl* prevStr =
+			 QChar c = (*prevStr)[prevStr->length() - 1];
+			 if (!c.isSpace())
+			     runOnString = true;
+		     }

Not sure about this from an RTL perspective.  Maybe Mitz could comment, but
that seems dangerous to me.

More information about the webkit-reviews mailing list