[webkit-reviews] review requested: [Bug 3230] CSS1: Words with inline elements get extra capital letters : [Attachment 6458] Proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Feb 13 04:44:28 PST 2006

Andrew Wellington <proton at wiretapped.net> has asked  for review:
Bug 3230: CSS1: Words with inline elements get extra capital letters

Attachment 6458: Proposed patch

------- Additional Comments from Andrew Wellington <proton at wiretapped.net>
While this doesn't use UBreakIterator, it does fix the problems we have
displaying the CSS1 test suite and should make all capitalisation obey the same
rules instead of inlines being able to break rendering (essentially we
capitalise the first letter after a space and nothing else).

Also added Copyright to StringImpl because I wrote the last fix for
capitalisation in here, otherwise it's hardly worth it :)

To be attached in a second after this, updated
LayoutTests/css2.1/support/css1test545.png for the new capitalisation behaviour
to draw the green box correctly.

More information about the webkit-reviews mailing list