[webkit-reviews] review granted: [Bug 7117] Add support for Win32
GIF rendering. : [Attachment 6307] The Cairo-specific back
end for images.
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Feb 6 18:29:38 PST 2006
Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 7117: Add support for Win32 GIF rendering.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7117
Attachment 6307: The Cairo-specific back end for images.
http://bugzilla.opendarwin.org/attachment.cgi?id=6307&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+ return buffer.duration() / 1000.;
Should be / 1000f instead, otherwise it will be done as double and then
converted to float rather than just done aas float.
+#include "config.h"
+#include <cairo.h>
+#include "GIFDecoderPlugin.h"
+#include "ImageDecoder.h"
+#include "IntSize.h"
Please put the include for the file's owner header first, so it tests whether
that header can stand alone. In this case it's "ImageDecoder.h" that should go
just after "config.h" and before other headers.
More information about the webkit-reviews
mailing list