[webkit-reviews] review denied: [Bug 7117] Add support for Win32
GIF rendering. : [Attachment 6310] The Image Viewer test
application.
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Feb 6 18:29:31 PST 2006
Eric Seidel <macdome at opendarwin.org> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 7117: Add support for Win32 GIF rendering.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7117
Attachment 6310: The Image Viewer test application.
http://bugzilla.opendarwin.org/attachment.cgi?id=6310&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
No need to check in generated files, they should be added to the svn:ignore
list on the directory instead.
All files should have the apple copyright and BSD license header if possible.
Image Viewer/ReadMe.txt seems of little use.
It's hard to tell which code here actually wants real review, I assume only the
cairo stuff... that part looks fine.
More information about the webkit-reviews
mailing list