[webkit-reviews] review denied: [Bug 7012] convert JavaScript objects to appropriate AppleScript types, instead of only strings : [Attachment 6267] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Feb 5 03:55:51 PST 2006

Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 7012: convert JavaScript objects to appropriate AppleScript types, instead
of only strings

Attachment 6267: proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
Please don't put a copy of tryGetAndCallProperty into WebCore. And if you feel
you must put a copy of it there, use ALWAYS_INLINE, not another copy of that
ifdef. Since you're using this specifically just to get a number, the function
can be simplified to handle just that case and leave out the type() stuff. The
code really needs to check exceptions, and not look at the return value if
there's an exception, so it's a pasted copy of incorrect code!

I think it's reasonable for some file in JavaScriptCore to provide a function
that gives you a date as a number or pair of numbers, and a boolean that tells
you whether it's a date, in a way analogous to functions like getString(),
rather than digging it out with multiple function calls to the date object.

On a separate note, one way to recognize the date class is by its class name,
which would avoid the need to include DateInstance and link to
DateInstance::info. You can just say if o->className() == "Date".

How are you testing this function? I think we need to hook this up to
DumpRenderTree so we can test that it's working.

More information about the webkit-reviews mailing list