[webkit-reviews] review requested: [Bug 7012] convert JavaScript objects to appropriate AppleScript types, instead of only strings : [Attachment 6267] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Feb 5 03:26:54 PST 2006


Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 7012: convert JavaScript objects to appropriate AppleScript types, instead
of only strings
http://bugzilla.opendarwin.org/show_bug.cgi?id=7012

Attachment 6267: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6267&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
Looks like I was doing the object->value convertion in a needlessly complex
way, and toPrimitive() already takes care of this stuff. However, I don't
really see where an isDate flag could be added, and if it would be less of an
implementation detail than DateInstance::info.



More information about the webkit-reviews mailing list