[webkit-reviews] review granted: [Bug 6525] REGRESSION: images dragged into contenteditable area end up outside of editable area (4414918) : [Attachment 6229] patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Vicki Murley <vicki at apple.com>'s
request for review:
Bug 6525: REGRESSION: images dragged into contenteditable area end up outside
of editable area (4414918)
http://bugzilla.opendarwin.org/show_bug.cgi?id=6525

Attachment 6229: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6229&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks great. I have 3 comments.

1) I think that since this returns nodeInfo it should probably be called
nodeInfoAtPoint:.

2) I'm surprised it compiles like this as I said above. Normally you need to
declare methods before you call them.

3) There's no need to construct the NodeInfo and then set it, you can just call
nodeAtPoint: on the same line where you declare it.

It's also possible the test case can be automated. We have the eventSender
object that can do mouse down events and move and then mouse up, which might
work for testing dragging.

I think I'll mark it review+, even given these comments.