[webkit-reviews] review denied: [Bug 6648] Safari strips-off namespace when using getAttribute() : [Attachment 6231] Patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Feb 3 19:40:19 PST 2006

Darin Adler <darin at apple.com> has denied Boris Daljevi&#263;
<boris at backbase.com>'s request for review:
Bug 6648: Safari strips-off namespace when using getAttribute()

Attachment 6231: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
I don't understand this patch.

The getAttribute, setAttribute, and removeAttribute implementations all do the
same thing, calling through to get/set/removeAttributeNS with a namespace URI
of null.

How can it possibly be correct to change only setAttribute and not the other

If you can answer that question, it seems OK to set this to review? again. By
the way, it's best to include the change log entry and the layout test case in
the patch.

More information about the webkit-reviews mailing list